Fix: nasl-cli/openvasd: stack overflow on prefix-statement #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichtsfrei
force-pushed
the
prefix-statement-crash
branch
from
7a93771
to
26b1fc7
Compare
Reported by @sepehrdaddev. To prevent prefix cases from hitting a stack overflow due to recursion it is reset after grouping parsing rather than handled per statement like in the loop.
nichtsfrei
force-pushed
the
prefix-statement-crash
branch
from
26b1fc7
to
a64e7d8
Compare
jjnicola
approved these changes
Nov 30, 2023
ArnoStiefvater
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @sepehrdaddev.
To prevent prefix cases from hitting a stack overflow due to recursion
it is reset after grouping parsing rather than handled per statement like
in the loop.
Jira: SC-965